fix(Django): Avoid evaluating complex Django object in span.data/span.attributes #4804
+77
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4804 +/- ##
=======================================
Coverage 84.56% 84.56%
=======================================
Files 158 158
Lines 16513 16521 +8
Branches 2866 2867 +1
=======================================
+ Hits 13964 13971 +7
Misses 1703 1703
- Partials 846 847 +1
|
…tsentry/sentry-python into antonpirker/django5-admin-improvement
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
![seer-by-sentry[bot]](https://avatars.githubusercontent.com/in/801464?s=60&v=4){kind=small}
antonpirker
changed the title
sl0thentr0py
requested changes
Sep 16, 2025
antonpirker
changed the title
…tsentry/sentry-python into antonpirker/django5-admin-improvement
antonpirker
changed the title
sl0thentr0py
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When rendering templates of the Django Admin in Django 5.0+ the template context includes also a
QuerySetwith lots of log items.In our
serialize()function this was not properly serialized leading to evaluating theQuerySet(read: running the SQL query).This change updates the
serialize()to also correctly serializeQuerySets inspan.dataIssues